Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[frontend] refactor: use representative main (#9521) #9522

Merged
merged 3 commits into from
Jan 16, 2025
Merged

[frontend] refactor: use representative main (#9521) #9522

merged 3 commits into from
Jan 16, 2025

Conversation

delemaf
Copy link
Member

@delemaf delemaf commented Jan 7, 2025

Proposed changes

  • Task name wasn't showing up
  • Refactor query to use representative.main instead of each entities/observables individually

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

@delemaf delemaf self-assigned this Jan 7, 2025
@github-actions github-actions bot added the filigran team use to identify PR from the Filigran team label Jan 7, 2025
@richard-julien richard-julien force-pushed the master branch 5 times, most recently from b414944 to c7f4cb7 Compare January 13, 2025 09:27
@codecov Codecov
Copy link

codecov bot commented Jan 16, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.23%. Comparing base (e32b9ec) to head (fb89d3b).
Report is 8 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #9522      +/-   ##
==========================================
+ Coverage   65.22%   65.23%   +0.01%     
==========================================
  Files         630      630              
  Lines       60201    60201              
  Branches     6741     6749       +8     
==========================================
+ Hits        39264    39271       +7     
+ Misses      20937    20930       -7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@delemaf
Copy link
Member Author

delemaf commented Jan 16, 2025

I've readded some name and observable_value because on add new container name or obesrvable_value is set but representative is not yet processed, so we can't only use representative this way (I tried to tweak updater but it's too shady this way)

@delemaf delemaf merged commit 7d9066b into master Jan 16, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ValentinBouzinFiligran ValentinBouzinFiligran ValentinBouzinFiligran approved these changes

Assignees

@delemaf delemaf

Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Task objects listed "Unknown"
2 participants
@delemaf @ValentinBouzinFiligran